Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze on incomplete for loop #1387

Open
decorator-factory opened this issue Dec 19, 2024 · 2 comments
Open

Freeze on incomplete for loop #1387

decorator-factory opened this issue Dec 19, 2024 · 2 comments

Comments

@decorator-factory
Copy link

It seems like #411 is still a problem.

Steps to reproduce:

  1. Go to https://lit.dev/tutorials/working-with-lists/#4
  2. Use this for the render method:
  render () {
    for (
  }
  1. The tab freezes

I'm on Firefox 133.0.3.

Maybe it would be reasonable to not update the playground if TypeScript emits an error, if it doesn't have a good way to communicate whether it's a syntax error or a type checking error?

@decorator-factory
Copy link
Author

I just checked the same conditions in Chromium, and the whole tab doesn't lock up.

The Origin-Agent-Cluster header mentioned in the old issue is not supported by Firefox and Safari and is still "experimental".

@e111077
Copy link
Collaborator

e111077 commented Feb 13, 2025

This is tricky because infinite loops are hard to detect in the setup we have for https://github.com/google/playground-elements which is what we use under the hood.

FWIW people that run into this issue via google – in order to kill the process you need to close every tab across your windows that has the https://lit.dev domain open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants