Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

Attachments in messages are ignored #117

Open
NikolayRys opened this issue Feb 7, 2017 · 1 comment
Open

Attachments in messages are ignored #117

NikolayRys opened this issue Feb 7, 2017 · 1 comment

Comments

@NikolayRys
Copy link
Contributor

NikolayRys commented Feb 7, 2017

Hi! Current implementation does not have any insights in messages that contain attachments, like this:
image
It does not even see the starting piece Event starting in 5 minutes:, but it would be totally reasonable to expect to happen. Since actually it's being a title of an attachment, it causes this slack adapter to miss it. We had to develop such feature for an internal project and currently we maintain it as a monkey patch, which is very inconvenient. I mean, a feature, which provides ability to match attachment components with regular routes(here it would beroute(/Event starting in 5 minutes:/) do ; end) and access to the attachment in the route body.
So I would like to submit it here, as a proper feature(turned off in config by default) with adequate test coverage. If I do, will this be accepted? I guess people can use that.

@NikolayRys NikolayRys changed the title Messages with attachments are ignored Attachments in messages are ignored Feb 8, 2017
@NikolayRys
Copy link
Contributor Author

NikolayRys commented May 11, 2017

Ok, I'll do a PR still, maybe then it'll be easier to evaluate the idea.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant