Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

Turn off auto formatting by default? #88

Open
Jinkxed opened this issue Apr 10, 2016 · 4 comments
Open

Turn off auto formatting by default? #88

Jinkxed opened this issue Apr 10, 2016 · 4 comments

Comments

@Jinkxed
Copy link

Jinkxed commented Apr 10, 2016

We are having an issue where the double quote in slack autoformats to different character.

From " to

This is how it was resolved in hubot. Can we look at doing something in lita-slack?

slackapi/hubot-slack@47a6fa9

@freibuis
Copy link
Contributor

has the formatting changed?

@Jinkxed
Copy link
Author

Jinkxed commented Apr 10, 2016

Not sure. I only ran into this because we are passing strings to the lita-rundeck gem and it was causing weird issues with quotes not being escaped. That's when I noticed it was a different character.

@jimmycuadra
Copy link
Contributor

Are you saying that you type a straight quote, Slack turns it into a smart quote, and then Lita receives it as a smart quote (which is not what you intended)?

@jimmycuadra
Copy link
Contributor

It seems reasonable that we convert from smart to straight quotes all the time, no config option needed. I seriously doubt anyone using Lita is intentionally trying to match on a smart quote. A PR for this would be welcome!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants