Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code style cleanups #120

Merged
merged 5 commits into from
Jan 31, 2025
Merged

Code style cleanups #120

merged 5 commits into from
Jan 31, 2025

Conversation

jrmybtlr
Copy link
Owner

This pull request includes several changes to improve code readability, consistency, and functionality across multiple files. The most important changes are grouped by theme below:

Code Consistency and Readability:

  • Updated function parameter formatting to place each parameter on a new line for better readability in src/actions.ts, src/animations.ts, and src/data.ts. [1] [2] [3]
  • Added commas at the end of the last elements in object literals and arrays to follow consistent coding style in docs/docs.mjs.

Bug Fixes:

  • Fixed the functionPattern regex to correctly match function definitions with multiline parameters in docs/docs.mjs.
  • Corrected the metadataPattern matching logic in docs/docs.mjs to improve metadata extraction.

Functional Enhancements:

  • Implemented reactive updates for device orientation detection in DetectDeviceOrientation.client.vue by using Vue's ref, onMounted, and onUnmounted hooks.
  • Improved the FormatDurationLabels.vue component to correctly handle the model-value binding and event updates. [1] [2]

Codebase Simplification:

  • Removed unnecessary parameters and streamlined function calls in docs/docs.mjs. [1] [2] [3]

ESLint Configuration:

  • Added a new ESLint configuration file eslint.config.mjs to include recommended settings for TypeScript and stylistic rules.

Copy link

cloudflare-workers-and-pages bot commented Jan 31, 2025

Deploying usemods-cf with  Cloudflare Pages  Cloudflare Pages

Latest commit: 35759c0
Status: ✅  Deploy successful!
Preview URL: https://fad5092b.usemods-cf.pages.dev
Branch Preview URL: https://code-style-cleanups.usemods-cf.pages.dev

View logs

@jrmybtlr jrmybtlr merged commit df4bf9f into main Jan 31, 2025
9 checks passed
@jrmybtlr jrmybtlr deleted the code-style-cleanups branch January 31, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant