For entried in visualize options without _count, append it#360
Draft
FlyingFish800 wants to merge 1 commit intomainfrom
Draft
For entried in visualize options without _count, append it#360FlyingFish800 wants to merge 1 commit intomainfrom
FlyingFish800 wants to merge 1 commit intomainfrom
Conversation
Collaborator
|
@yql5510718 could you try out this patch, review and accept if ok? |
Collaborator
|
does this handles the _count already? |
Collaborator
|
Can you test with and without the patch. Last time I checked I had to
append _count
…On Mon, Mar 30, 2026, 11:00 AM Yuanpeng Liao ***@***.***> wrote:
*yql5510718* left a comment (litz-lab/scarab-infra#360)
<#360?email_source=notifications&email_token=AA3EU7RGKVJCL5O5ZZQSFBT4TKY2TA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJVG4YDEMJRGA3KM4TFMFZW63VQOJSXM2LFO5PXEZLROVSXG5DFMSSWK5TFNZ2LK4DSL5RW63LNMVXHIX3POBSW4X3DNRUWG2Y#issuecomment-4157021106>
does this
<https://github.com/litz-lab/scarab-infra/blob/a47ef85d1178daf3cb657363bc26fc4e5c055253/sci#L2826>
handles the _count already?
—
Reply to this email directly, view it on GitHub
<#360?email_source=notifications&email_token=AA3EU7RGKVJCL5O5ZZQSFBT4TKY2TA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJVG4YDEMJRGA3KM4TFMFZW63VQOJSXM2LFO5PXEZLROVSXG5DFMSSWK5TFNZ2LK4DSL5RW63LNMVXHIX3POBSW4X3DNRUWG2Y#issuecomment-4157021106>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA3EU7QBRXQG54VCWB2HVY34TKY2TAVCNFSM6AAAAACXC5BHJKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCNJXGAZDCMJQGY>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Collaborator
|
This was introduced PR #246 , and it works on my side. |
Collaborator
|
I think I already removed _count in the JSON, and it should always automatically append it when we find the stats from collected_stats.csv? (#246) |
Collaborator
|
#354 mentions _value not _count. without appending "_value", I am getting: Skipping ['SIM_HOST_WALL_SECONDS']: not present in collected stats (SIM_HOST_WALL_SECONDS). |
Collaborator
Author
|
@hlitz When I try to vizualize SIM_HOST_WALL_SECONDS_value, I get |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For any entry in the stat visualization section of the json file, check if the counter name is missing '_count'. If it is, append it.
Closes #354