Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False Positives #84

Open
ghost opened this issue Nov 17, 2016 · 0 comments
Open

False Positives #84

ghost opened this issue Nov 17, 2016 · 0 comments

Comments

@ghost
Copy link

ghost commented Nov 17, 2016

Not sure if it's fixable, but I think it's important to at least make the issue known.

There is a possibility that running fastest will say a test has passed when it shouldn't. The only cause I have been able to create this issue with is having two classes with the same name but separate namespaces used in a test - e.g. My\First\FileSystem and My\Second\FileSystem. Both of which have the same number & type of arguments in their constructors.

Ordinarily, when running tests as standard, this will immediately be picked up and cause an error. It's possible when running fastest that these two classes will never be around each other at any time during testing, and the test will pass. Tests pass -> Missed it in a peer review -> Deploy to staging -> balls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants