Skip to content

Commit c1b4468

Browse files
committed
fix: Remove @octokit/rest to fix security vulnerability
close #105
1 parent c6b10a4 commit c1b4468

File tree

7 files changed

+769
-1015
lines changed

7 files changed

+769
-1015
lines changed

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,3 +97,5 @@ build
9797

9898
# TernJS port file
9999
.tern-port
100+
101+
.mkcert

biome.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
"useNamespaceKeyword": "error"
3434
}
3535
},
36-
"ignore": ["**/build", "**/dist", "**/scripts", "**/node_modules"]
36+
"ignore": ["dist", "node_modules"]
3737
},
3838
"javascript": {
3939
"formatter": {

package.json

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -36,28 +36,29 @@
3636
}
3737
},
3838
"scripts": {
39-
"test": "pnpm build && del /Q \"./node_modules/.mkcert\" && vite -c playground/vite.config.ts --clearScreen false",
40-
"build": "tsx ./script/build.mts",
39+
"test": "pnpm build && pnpm playground",
40+
"playground": "rimraf .mkcert && vite -c playground/vite.config.ts --clearScreen false",
41+
"build": "tsx ./scripts/build.mts",
4142
"lint": "tsc --noEmit && biome lint --colors=force --fix --unsafe \"plugin\" ",
4243
"release": "semantic-release"
4344
},
4445
"dependencies": {
45-
"@octokit/rest": "^21.0.2",
46-
"axios": "^1.7.7",
47-
"debug": "^4.3.7",
46+
"axios": "^1.8.1",
47+
"debug": "^4.4.0",
4848
"picocolors": "^1.1.1"
4949
},
5050
"devDependencies": {
5151
"@biomejs/biome": "1.9.4",
5252
"@semantic-release/changelog": "^6.0.3",
5353
"@semantic-release/git": "^10.0.1",
5454
"@types/debug": "^4.1.12",
55-
"@types/node": "^22.9.0",
56-
"esbuild": "^0.24.0",
57-
"semantic-release": "^24.2.0",
58-
"tsx": "^4.19.2",
59-
"typescript": "^5.6.3",
60-
"vite": "5.4.11"
55+
"@types/node": "^22.13.5",
56+
"esbuild": "^0.25.0",
57+
"semantic-release": "^24.2.3",
58+
"tsx": "^4.19.3",
59+
"rimraf": "^6.0.1",
60+
"vite": "6.2.0",
61+
"typescript": "^5.7.3"
6162
},
6263
"peerDependencies": {
6364
"vite": ">=3"

playground/main.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import './style.css'
22

3+
// biome-ignore lint/style/noNonNullAssertion: <explanation>
34
const app = document.querySelector<HTMLDivElement>('#app')!
45

56
app.innerHTML = `

playground/vite.config.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { defineConfig } from 'vite'
2-
import path from 'path'
2+
import path from 'node:path'
33

44
import mkcert from '..'
55

@@ -8,7 +8,7 @@ export default defineConfig({
88
plugins: [
99
mkcert({
1010
source: 'coding',
11-
savePath: path.resolve(process.cwd(), 'node_modules/.mkcert')
11+
savePath: path.resolve(process.cwd(), '.mkcert')
1212
})
1313
]
1414
})

plugin/mkcert/source.ts

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import { Octokit } from '@octokit/rest'
2-
31
import request from '../lib/request'
42

53
export type SourceInfo = {
@@ -31,15 +29,13 @@ export class GithubSource extends BaseSource {
3129
}
3230

3331
public async getSourceInfo(): Promise<SourceInfo | undefined> {
34-
const octokit = new Octokit()
35-
const { data } = await octokit.repos.getLatestRelease({
36-
owner: 'FiloSottile',
37-
repo: 'mkcert'
32+
const { data } = await request({
33+
method: 'GET',
34+
url: 'https://api.github.com/repos/FiloSottile/mkcert/releases/latest',
3835
})
3936
const platformIdentifier = this.getPlatformIdentifier()
40-
4137
const version = data.tag_name
42-
const downloadUrl = data.assets.find(item =>
38+
const downloadUrl = data.assets.find((item: any) =>
4339
item.name.includes(platformIdentifier)
4440
)?.browser_download_url
4541

0 commit comments

Comments
 (0)