Skip to content

Commit ec291cf

Browse files
committed
Move the uniffi-dart pin back to upstream
The multi-crate codegen fixes (Uniffi-Dart/uniffi-dart#150, #154, #156) are all merged upstream, so the temporary pin to the contributor fork is no longer needed. Pin the current upstream main rev, as no release tag has been cut since v0.2.1. Upstream codegen now emits ignore_for_file hints and drops unused imports, but it introduces unused locals in async callback trampolines, so add unused_local_variable to the generated-code lint ignores.
1 parent 5a7e749 commit ec291cf

3 files changed

Lines changed: 12 additions & 10 deletions

File tree

‎Cargo.lock‎

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎livekit-uniffi/Cargo.toml‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@ thiserror = { workspace = true }
2929
# Dart binding generator. Not published to crates.io, so pinned by git rev. The
3030
# rev must target the same uniffi-rs release (0.31) as the `uniffi` dependency
3131
# above, or it cannot read this crate's compiled metadata.
32-
# TEMPORARY: pinned to the multi-crate codegen fixes on ryangaus's fork
33-
# (upstream is dormant; PR Uniffi-Dart/uniffi-dart#150 is one of them). Move
34-
# the pin back to upstream once merged, or to a livekit-maintained fork if a
35-
# release needs cutting before that (CLT-2872).
36-
uniffi-dart = { git = "https://github.com/1egoman/uniffi-dart", rev = "ee04fd038659a9bd1438cbd297707861a55fd2f7", optional = true }
32+
# Pinned to upstream main from 2026-08-31, which carries the multi-crate
33+
# codegen fixes (Uniffi-Dart/uniffi-dart#150/#154/#156) this crate needs,
34+
# previously consumed from a contributor fork. Upstream has published no
35+
# release tag since v0.2.1, hence a rev pin rather than a tag.
36+
uniffi-dart = { git = "https://github.com/Uniffi-Dart/uniffi-dart", rev = "67547701d849c9ef6302f79bb2189bb6075f69fa", optional = true }
3737
camino = { version = "1", optional = true }
3838

3939
[features]
Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
1-
# The package contents are generated by uniffi-dart, which emits imports and
2-
# helpers that are not always used by the exported surface. Silence those
3-
# lints so pub.dev validation stays clean; real analysis errors still fail.
1+
# The package contents are generated by uniffi-dart, which emits imports,
2+
# helpers, and locals that are not always used by the exported surface.
3+
# Silence those lints so pub.dev validation stays clean; real analysis
4+
# errors still fail.
45
analyzer:
56
errors:
67
unused_import: ignore
78
unnecessary_import: ignore
89
unused_element: ignore
10+
unused_local_variable: ignore

0 commit comments

Comments
 (0)