feat: add cropping via vips #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knarewski
force-pushed
the
feat-add-vips-crop
branch
from
f4d655c to
bdc3cea
Compare
knarewski
force-pushed
the
feat-add-vips-crop
branch
from
bdc3cea to
7eeedc9
Compare
The difference in reference images:
- plasma-cropped-excessive-size - MAE (mean average error): 0.00950674
- plasma-cropped - MAE: 0.0107107
- plasma-cropped-negative-initial-coords - MAE: 0.00959682
- plasma-cropped-1x1 - no difference, duplicated in vips directory for completeness
- plasma-auto-cropped - MAE: 0.0181914 , also one pixel difference in height (pixbuf trims 243.75 down, vips rounds it up)
it also required adding tolerance due to differences between vips used on development and CI; (MAE: 0.00480813)
Libvips crop output appears a bit more noisy, but it seems to better resemble the original
knarewski
force-pushed
the
feat-add-vips-crop
branch
from
7eeedc9 to
c0925db
Compare
Surge9
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
GdkPixbuf-based image processing can take over 1GB of memory for processing a single high-resolution photo. We've decided to introduce another processor, hoping that it'll improve Morandi's memory profile and performance.
Problems
Vips processor doesn't support cropping
Solution
Add support for cropping
Pixbuf vs Vips comparison
0.01071070.00950674Other images can be compared by opening files with identical names in
spec/fixtures/reference_images/andspec/fixtures/reference_images/vips/Libvips crop output appears to be more noisy, but after visual inspection it seems to be more similar to the original