98 data phx ref support#255
Draft
mobile-bungalow wants to merge 28 commits intoliveview-native:mainfrom
Draft
Conversation
simlay
reviewed
Dec 12, 2024
Contributor
simlay
left a comment
simlay
left a comment
There was a problem hiding this comment.
This is pretty good. I know there's some merge conflicts due to #256. The changes are deep into the patch diffing that I've avoided.
I think the attr, element, const_attr macros make the tests a lot nicer. I'd just suggest that they be in the test modules.
Comment on lines
+7
to
+28
| #[macro_export] | ||
| macro_rules! attr { | ||
| ($name:literal) => { | ||
| Attribute::new($name, None) | ||
| }; | ||
| ($name:literal= $value:expr) => { | ||
| Attribute::new($name, Some($value.to_string())) | ||
| }; | ||
| ($namespace:literal : $name:literal) => { | ||
| Attribute { | ||
| name: AttributeName::new_with_namespace($namespace, $name), | ||
| value: None, | ||
| } | ||
| }; | ||
| ($namespace:literal : $name:literal = $value:expr) => { | ||
| Attribute { | ||
| name: AttributeName::new_with_namespace($namespace, $name), | ||
| value: Some($value.to_string()), | ||
| } | ||
| }; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
At this moment, I think this macro is only used in tests so it should probably go behind a #[cfg(test)] or in a test module.
| } | ||
|
|
||
| #[macro_export] | ||
| macro_rules! element { |
Contributor
There was a problem hiding this comment.
Same thing about this only being used in tests.
Comment on lines
+160
to
+166
| element!( | ||
| "Button", | ||
| attr!("id" = "button"), | ||
| attr!("phx-click" = "inc_temperature"), | ||
| attr!("data-phx-ref-src" = "5"), | ||
| attr!("class" = "phx-click-loading") | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.