Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pix2pix and inpainting models #5

Open
ljleb opened this issue Feb 17, 2024 · 2 comments
Open

Add support for pix2pix and inpainting models #5

ljleb opened this issue Feb 17, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@ljleb
Copy link
Owner

ljleb commented Feb 17, 2024

Merging a pix2pix or inpainting model with a normal model yet does not work. We need to catch dimension mismatches in the shapes of the tensors and take appropriate action. We need to look around on github, I'm pretty sure there is code for this already somewhere.

@ljleb ljleb added the enhancement New feature or request label Feb 17, 2024
@ljleb
Copy link
Owner Author

ljleb commented Feb 17, 2024

Yes, but I'm not sure this is how it's supposed to be done. Instead of ignoring the keys, we should test slicing, merging and concat. I forgot to specify this in the OP, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants