Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save lora #9

Open
ljleb opened this issue Feb 17, 2024 · 0 comments
Open

Save lora #9

ljleb opened this issue Feb 17, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ljleb
Copy link
Owner

ljleb commented Feb 17, 2024

Loading lora models has been implemented. However, it's not yet possible to save the merge result as a lora. While it wouldn't make sense to do this for full models, if the result happens to be in delta space, then we can apply the SVD algorithm on the appropriate keys. I was thinking we could add a new method merge_and_save_lora that only accepts a recipe that results in delta space. Like this, we can catch mistakes if a recipe doesn't do what it intends to and we can keep the current merge_and_save method as-is.

@ljleb ljleb added the enhancement New feature or request label Feb 17, 2024
@ljleb ljleb mentioned this issue Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant