add log and update test

Signed-off-by: Francisco Javier Arceo <[email protected]>

Author: franciscojavierarceo

src/llama_stack/providers/utils/memory/openai_vector_store_mixin.py

@@ -112,9 +112,10 @@ async def _rewrite_query_for_search(self, query: str) -> str:
             or not self.vector_stores_config.rewrite_query_params
             or not self.vector_stores_config.rewrite_query_params.model
         ):
-            raise ValueError(
-                "Query rewriting requested but not configured. Please configure rewrite_query_params.model in vector_stores config."
+            logger.warning(
+                "User is trying to use vector_store query rewriting, but it is not configured. Please configure rewrite_query_params.model in vector_stores config."
             )
+            raise ValueError("Query rewriting is not available")
 
         model = self.vector_stores_config.rewrite_query_params.model
         model_id = f"{model.provider_id}/{model.model_id}"

tests/integration/vector_io/test_openai_vector_stores.py

@@ -1750,4 +1750,4 @@ def test_openai_vector_store_search_with_rewrite_query(
 
     # Verify the error message indicates missing query rewriting configuration
     error_message = str(exc_info.value)
-    assert "Query rewriting requested but not configured" in error_message
+    assert "Query rewriting is not available" in error_message

tests/unit/providers/vector_io/test_vector_io_openai_vector_stores.py

@@ -1232,8 +1232,8 @@ async def test_embedding_config_required_model_missing(vector_io_adapter):
         await vector_io_adapter.openai_create_vector_store(params)
 
 
-async def test_query_expansion_functionality(vector_io_adapter):
-    """Test query expansion with instance-based configuration approach."""
+async def test_query_rewrite_functionality(vector_io_adapter):
+    """Test query rewrite with instance-based configuration approach."""
     from unittest.mock import MagicMock
 
     from llama_stack.core.datatypes import QualifiedModel, RewriteQueryParams
@@ -1261,10 +1261,10 @@ async def mock_query_chunks(*args, **kwargs):
 
     # Mock chat completion for query rewriting
     vector_io_adapter.inference_api.openai_chat_completion = AsyncMock(
-        return_value=MagicMock(choices=[MagicMock(message=MagicMock(content="expanded test query"))])
+        return_value=MagicMock(choices=[MagicMock(message=MagicMock(content="rewritten test query"))])
     )
 
-    # Test 1: Query expansion with default prompt (no custom prompt configured)
+    # Test 1: Query rewrite with default prompt (no custom prompt configured)
     mock_vector_stores_config = MagicMock()
     mock_vector_stores_config.rewrite_query_params = RewriteQueryParams(
         model=QualifiedModel(provider_id="test", model_id="llama"), max_tokens=100, temperature=0.3
@@ -1295,7 +1295,7 @@ async def mock_query_chunks(*args, **kwargs):
     # Verify the adapter's query_chunks was called with rewritten query
     assert result is not None  # Search should return a result
 
-    # Test 1b: Query expansion with custom prompt override and inference parameters
+    # Test 1b: Query rewrite with custom prompt override and inference parameters
 
     mock_vector_stores_config.rewrite_query_params = RewriteQueryParams(
         model=QualifiedModel(provider_id="test", model_id="llama"),
@@ -1325,7 +1325,7 @@ async def mock_query_chunks(*args, **kwargs):
     # Clear config on the adapter
     vector_io_adapter.vector_stores_config = None
 
-    with pytest.raises(ValueError, match="Query rewriting requested but not configured"):
+    with pytest.raises(ValueError, match="Query rewriting is not available"):
         await vector_io_adapter.openai_search_vector_store(
             vector_store_id=vector_store_id, query="test query", rewrite_query=True, max_num_results=5
         )