ScaFFold benchmark fixes and torchrun-hpc launcher option#1234
Open
michaelmckinsey1 wants to merge 13 commits intodevelopfrom
Open
ScaFFold benchmark fixes and torchrun-hpc launcher option#1234michaelmckinsey1 wants to merge 13 commits intodevelopfrom
torchrun-hpc launcher option#1234michaelmckinsey1 wants to merge 13 commits intodevelopfrom
Conversation
github-actions
bot
added
feature
Collaborator
Author
|
https://lc.llnl.gov/gitlab/benchpark/benchpark/-/jobs/3346658 failure here means I think I would need |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1234 +/- ##
===========================================
+ Coverage 62.83% 64.43% +1.60%
===========================================
Files 48 48
Lines 3643 3644 +1
Branches 279 279
===========================================
+ Hits 2289 2348 +59
+ Misses 1345 1287 -58
Partials 9 9
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
torchrun-hpcas launcher forfluxandslurmschedulers (native launchers will not work).benchpark experiment init ... allocation=torchrun-hpc