Conversation
Member
|
This looks really good, thanks for the contribution @abagusetty! Do you have some more extensions in mind before moving this forward? |
Author
Hi @trws Thanks for taking a peek. I just wanted to make sure this works on (a) Intel PVC (a few combinations) (b) get in touch with @homerdin related to a use case (c) a bit extended -- run on CUDA and HIP devices (d) Do a sanity check with Umpire. Shouldn't be more than day or so. Will gently ping you, when ready. Thanks again! |
Member
|
Sounds great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly minor cleanup to comply with SYCL spec and add a few features (extensions from oneapi)