Rework AtenEmptyStridedOp checks (#2537)

Now using Value instead of Ints. Trades compile failure for a runtime
assert

Author: dan-garvey

e2e_testing/xfail_sets.py

@@ -764,6 +764,7 @@
     "NewEmptyModuleNonDefaultIntDtype_basic",
     "NewEmptyStridedModuleDefaultDtype_basic",
     "EmptyStridedModule_basic",
+    "EmptyStridedSizeIntStrideModule_basic",
     "PermuteModule_basic",
     "PermuteNegativeIndexModule_basic",
     "ReduceSumDimIntListKeepDimNegativeDimStaticModule_basic",
@@ -1440,6 +1441,7 @@
     "UniformStaticShapeModule_basic",
     "AtenEmbeddingBagStaticModule_basic",
     "EmptyStridedModule_basic",
+    "EmptyStridedSizeIntStrideModule_basic",
     "ElementwiseBitwiseAndScalarInt64Module_basic",
     "ElementwiseBitwiseAndScalarInt32Module_basic",
     "ElementwiseBitwiseAndScalarInt8Module_basic",

include/torch-mlir/Dialect/Torch/Utils/Utils.h

@@ -104,6 +104,12 @@ inline bool isAssumingStrictSymbolicShapes(OpBuilder &builder) {
   return isAssumingStrictSymbolicShapes(builder.getBlock());
 }
 
+// Helper function for AtenEmptyStrided and friends that checks if the stride
+// values are default or not. Throws a runtime assert if not.
+LogicalResult checkDefaultStrideHelper(Operation *op, PatternRewriter &rewriter,
+                                       Value opSize, Value opStride,
+                                       Location loc);
+
 } // namespace Torch
 } // namespace torch
 } // namespace mlir