-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some action doesn't include AttackType #5
Comments
Hi, I don't think ActionCategory is reliable for determining if an action is magic damage or not. I can try to find another solution to these kinds of issues |
I just notice there a big different between those how about search another action with the same name, like below foreach (var tmp in actionSheet)
{
if ((DamageType)tmp.AttackType.Row == DamageType.Unknown || row.Name == null || row.Name == "") continue;
if (tmp.Name == row.Name)
{
tmpType = (DamageType)tmp.AttackType.Row;
break;
}
} |
There is no guarantee that two actions with the same name will be the same damage type |
yeah, you are right. I find some actions like Terminus Est, Fireball with the same name but different AttckType. but most of them, are using the same type. Maybe could use current finding write a filter? Set it as an option of plugin. In addition, it causes more time when initializing the plugin (close to crash the game lol). |
like action
22803
Tender Loin doesn't include AttackType. However, it has been used in ColorCastBar. The name of action '22804' is the same as action22803
but it includes AttackType. This problem causes the type of action22803
to become aDamageType.Unknown
.i think the program could use ActionCategory instead of AttackType when not available.
The text was updated successfully, but these errors were encountered: