Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some action doesn't include AttackType #5

Open
LittleNightmare opened this issue May 8, 2021 · 4 comments
Open

some action doesn't include AttackType #5

LittleNightmare opened this issue May 8, 2021 · 4 comments

Comments

@LittleNightmare
Copy link

like action 22803 Tender Loin doesn't include AttackType. However, it has been used in ColorCastBar. The name of action '22804' is the same as action 22803 but it includes AttackType. This problem causes the type of action 22803 to become a DamageType.Unknown.

i think the program could use ActionCategory instead of AttackType when not available.

@lmcintyre
Copy link
Owner

Hi, I don't think ActionCategory is reliable for determining if an action is magic damage or not. I can try to find another solution to these kinds of issues

@LittleNightmare
Copy link
Author

LittleNightmare commented May 8, 2021

I just notice there a big different between those

how about search another action with the same name, like below

                    foreach (var tmp in actionSheet)
                    {
                        if ((DamageType)tmp.AttackType.Row == DamageType.Unknown || row.Name == null || row.Name == "") continue;
                        if (tmp.Name == row.Name)
                        {
                            tmpType = (DamageType)tmp.AttackType.Row;
                            break;
                        }
                        
                    }

@lmcintyre
Copy link
Owner

There is no guarantee that two actions with the same name will be the same damage type

@LittleNightmare
Copy link
Author

yeah, you are right. I find some actions like Terminus Est, Fireball with the same name but different AttckType. but most of them, are using the same type. Maybe could use current finding write a filter? Set it as an option of plugin. In addition, it causes more time when initializing the plugin (close to crash the game lol).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants