Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image classification code, image rescaling missing when images uploaded (rock paper scissors and horse/humans dataset) #129

Open
HaraBeron opened this issue Jul 26, 2020 · 1 comment

Comments

@HaraBeron
Copy link

HaraBeron commented Jul 26, 2020

I have a comment regarding the following code:
https://github.com/lmoroney/dlaicourse/blob/09767115b53c8ac99df7b85fc67a3cea9fed2482/Course%202%20-%20Part%208%20-%20Lesson%202%20-%20Notebook%20(RockPaperScissors).ipynb

At the end there are images uploaded and the model applied to give predictions for the specific uploaded image. However, we should also rescale the values to [0,1] (by dividing by 255). We are doing this when applying the imagedatagenerator. When we manually upload the images, we just resize, but don't rescale. It is necessary to add the rescaling.

Same problem in case of horse and humans in the parts where images are uploaded (uploaded = files.upload()):
https://github.com/lmoroney/dlaicourse/blob/842e3b1099082dc8631301c26afb6ec71f158eee/Course%201%20-%20Part%208%20-%20Lesson%204%20-%20Notebook.ipynb

https://github.com/lmoroney/dlaicourse/blob/8349cf3839603254b2e41fcc15007f6b8a0de39c/Course%201%20-%20Part%208%20-%20Lesson%202%20-%20Notebook.ipynb

https://github.com/lmoroney/dlaicourse/blob/8349cf3839603254b2e41fcc15007f6b8a0de39c/Course%201%20-%20Part%208%20-%20Lesson%203%20-%20Notebook.ipynb

https://github.com/lmoroney/dlaicourse/blob/842e3b1099082dc8631301c26afb6ec71f158eee/Horse_or_Human_NoValidation.ipynb

@HaraBeron HaraBeron changed the title Image classification code, image rescaling missing Image classification code, image rescaling missing when images uploaded (rock paper scissors and horse/humans dataset) Jul 26, 2020
@chinitaberrio
Copy link

I have noticed the same! I tried to reach out to Coursera but it was impossible to get an answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants