Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course 3 - Week 2 - Lesson 3.ipynb error #134

Open
rbhambriiit opened this issue Aug 29, 2020 · 2 comments
Open

Course 3 - Week 2 - Lesson 3.ipynb error #134

rbhambriiit opened this issue Aug 29, 2020 · 2 comments

Comments

@rbhambriiit
Copy link

https://github.com/lmoroney/dlaicourse/blob/master/TensorFlow%20In%20Practice/Course%203%20-%20NLP/Course%203%20-%20Week%202%20-%20Lesson%203.ipynb

history = model.fit(train_data, epochs=num_epochs, validation_data=test_data)
hits error.

fix:
replace train_data with train_dataset
replace test_data with test_dataset

@rbhambriiit rbhambriiit changed the title Course 3 - Week 2 - Lesson 3.ipynb Course 3 - Week 2 - Lesson 3.ipynb error Aug 29, 2020
@rbhambriiit
Copy link
Author

also i see:

Epoch 10/10
391/391 [==============================] - 16s 41ms/step - loss: 0.1622 - accuracy: 0.9431 - val_loss: 0.3225 - val_accuracy: 0.8786

course video expects this to be ~60%

@juan-coursera
Copy link
Contributor

Hi rbhambriiit,

Yes, it should be train_dataset and test_dataset. This was a typo on my part. I made a pull request #110 back in June 12th to fix this. I'm waiting for it to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants