New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OnionMessenger to use ChannelManager as message handler #14

Open

kannapoix opened this issue Nov 4, 2024 · 0 comments · May be fixed by #15

kannapoix commented Nov 4, 2024 •

edited

Loading

We are using our own OnionMessenger type which implements our own OffersMessageHandler implementation.
We can now use the LDK default SimpleArcOnionMessenger as OnionMessenger, because LDK ChannelManager now implements OffersMessageHandler.

This is already pointed out as a code comment:

ldk-sample/src/lib.rs

Lines 182 to 183 in 57b5e50

    
           // TODO: We should sync this with ldk-sample. Now ChannelManager implements the OnionMessageHandler 
        
           // and we no longer need to do this.

kannapoix linked a pull request

that will close this issue

Use LDK ChannelManager for OfferMessageHandler #15

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment