Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading names for temperature control PID parameters #5

Open
henriquesimoes opened this issue Mar 3, 2023 · 0 comments
Open

Misleading names for temperature control PID parameters #5

henriquesimoes opened this issue Mar 3, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@henriquesimoes
Copy link

As it has been reported at lnls-dig/bpm-epics-ioc#35, PID parameters are named after the standard form constants (Kp, Ti, Td), however they are implemented as Kp, Ki and Kd.

The point where this renaming occurs (without the proper transformation) is in the config_get_pid_ac() (and _bd) function call.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@henriquesimoes