Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git tag prefix #404

Closed
drieks opened this issue Jul 24, 2023 · 7 comments
Closed

git tag prefix #404

drieks opened this issue Jul 24, 2023 · 7 comments
Labels
bug Something isn't working
Milestone

Comments

@drieks
Copy link

drieks commented Jul 24, 2023

Describe the bug

Hi,

it seems that you removed the tag name prefix "v", versions up to v1.1.0 starts with "v", 1.1.1 and 1.1.2 don't have this prefix. Version 1.1.0 was released both with and without prefix.

This breaks at least flatpack and two arch linux aur scripts:

flatpak install com.obsproject.Studio.Plugin.BackgroundRemoval

https://aur.archlinux.org/packages/obs-backgroundremoval-git
https://aur.archlinux.org/packages/obs-backgroundremoval

All of them are still on the latest version with prefix "v", so it is currently not possible to install the latest version on arch linux based systems.

To Reproduce

Try to install the latest version from any of this sources:
flatpak install com.obsproject.Studio.Plugin.BackgroundRemoval

https://aur.archlinux.org/packages/obs-backgroundremoval-git
https://aur.archlinux.org/packages/obs-backgroundremoval

Expected behavior

The latest version should be installed.

Screenshots

Log and Crash Report

Desktop (please complete the following information):

  • OS: manjaro linux

Additional context

@royshil
Copy link
Collaborator

royshil commented Jul 24, 2023

Shoot. This was a requirement from the latest OBS plugin template build scripts. We'll have to fix this on there

@royshil
Copy link
Collaborator

royshil commented Jul 25, 2023

@umireon what do you make of this?
should we release v1.1.3 with the existing stuff and fix the build scripts provided by OBS?
or should we strive to fix it on the AUR and Flatpak?

@umireon
Copy link
Member

umireon commented Jul 25, 2023

I want to ask obs-studio/obs-plugintemplate why they removed the v prefix.

@royshil
Copy link
Collaborator

royshil commented Jul 25, 2023

@umireon i actually was the one who removed the v from the tag, but that was because the plugin template would not create the package correctly.

however, for now we can simple apply two tags 1.1.3 and v1.1.3 for the same commit, and only create release based on the 1.1.3
but the flatpack and AUR will still be able to download the source from github
what do you think?

@royshil royshil added this to the 1.1.3 milestone Jul 26, 2023
@umireon
Copy link
Member

umireon commented Jul 27, 2023

I'm asking this on upstream now: obsproject/obs-plugintemplate#86

@royshil royshil modified the milestones: 1.1.3, 1.1.4 Jul 31, 2023
@umireon
Copy link
Member

umireon commented Aug 23, 2023

I suppose the removal of the prefix "v" is intentional on the upstream and we have to fix Flatpak and AUR to conform to the new tag format.

@umireon umireon modified the milestones: 1.1.4, 1.1.5 Aug 23, 2023
@umireon
Copy link
Member

umireon commented Sep 22, 2023

I'm going to change all the build definitions to use the tag without v prefix.

@umireon umireon closed this as completed Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants