Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ValidationError for CloudFormation.DescribeStacks #5978

Merged
merged 3 commits into from
May 2, 2022
Merged

Fix ValidationError for CloudFormation.DescribeStacks #5978

merged 3 commits into from
May 2, 2022

Conversation

dominikschubert
Copy link
Member

Hotfix for a regression that prevented AWS CDK from bootstrapping since the DescribeStacks response couldn't be parsed successfully.

Fixes localstack/aws-cdk-local#68

@dominikschubert dominikschubert self-assigned this May 2, 2022
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests May 2, 2022 13:20 Inactive
@dominikschubert dominikschubert added the aws:cloudformation AWS CloudFormation label May 2, 2022
@dominikschubert dominikschubert requested review from thrau and steffyP May 2, 2022 13:20
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests May 2, 2022 13:22 Inactive
thrau
thrau approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking this one @dominikschubert.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 91.914% when pulling 62d80c4 on fix_cloudformation-describe-errormsg into d29ea3e on master.

@github-actions
Copy link

github-actions bot commented May 2, 2022

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 3m 39s ⏱️ +55s
   978 tests ±0     938 ✔️ ±0  40 💤 ±0  0 ❌ ±0 
1 196 runs  ±0  1 128 ✔️ ±0  68 💤 ±0  0 ❌ ±0 

Results for commit 62d80c4. ± Comparison against base commit d29ea3e.

@thrau thrau merged commit 172eff9 into master May 2, 2022
@thrau thrau deleted the fix_cloudformation-describe-errormsg branch May 2, 2022 14:34
@jts-mjanda
Copy link

Any idea of when this fix will be generally available?

@thrau
Copy link
Member

thrau commented May 3, 2022

hi @jts-mjanda , the fix should already be in the docker image with the tag latest

@jts-mjanda
Copy link

Thank you. Confirmed both locally as well as on CircleCI. Thank you for the quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrau thrau thrau approved these changes

@steffyP steffyP Awaiting requested review from steffyP

Assignees

@dominikschubert dominikschubert

Labels
aws:cloudformation AWS CloudFormation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bootstrap Error Stack with id %s does not exist CDKToolkit
4 participants
@dominikschubert @coveralls @jts-mjanda @thrau