Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-account with LocalStack PRO and cdklocal does not honor the custom account ID #74

Closed
dominikschubert opened this issue Oct 18, 2022 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@dominikschubert
Copy link
Member

export AWS_ACCESS_KEY_ID=000000000001
export AWS_SECRET_ACCESS_KEY=test
export AWS_REGION=us-east-1

cdklocal bootstrap

Expected behavior: LocalStack creates an ECR repository in account 000000000001
Actual behavior: LocalStack creates an ECR repository in account 000000000000

@dominikschubert dominikschubert added the bug Something isn't working label Oct 18, 2022
@dominikschubert dominikschubert self-assigned this Oct 18, 2022
@vincenthongzy
Copy link

@dominikschubert apologies for the ping, is this issue still being looked into?

@whummer
Copy link
Member

whummer commented Aug 25, 2023

@dominikschubert Just gave this a quick try with the latest version of LocalStack and cdklocal (using CDK version 2.62.2).

$ cd /tmp
$ export AWS_ACCESS_KEY_ID=000000000001 AWS_SECRET_ACCESS_KEY=test AWS_REGION=us-east-1
$ cdklocal init app --language=python
...
$ pip install -r requirements.txt
...
$ cdklocal bootstrap
...
 ✅  Environment aws://000000000001/us-east-1 bootstrapped.
...
$ awslocal ecr describe-repositories | grep repositoryName
...
            "repositoryName": "cdk-hnb659fds-container-assets-000000000001-us-east-1",
...

Looks like this issue is potentially already solved in the meantime?

@vincenthongzy Are you able to replicate these results? Please note that for ECR to work fully end-to-end, you'll need a LocalStack Pro license (free trial available). Please keep us posed on how it goes.. Thanks!

@lakkeger
Copy link
Contributor

Hi @vincenthongzy! We just wanted to follow up to see whether your issue has been resolved. Were you able to get it working with the latest version of LocalStack? We would appreciate your feedback!

@vincenthongzy
Copy link

Apologies for the late reply, but yes this does work with the latest version of localstack-pro and aws-cdk-local !

@lakkeger
Copy link
Contributor

Thank you for your feedback. We are delighted it's working! If you experience any other issues, please do not hesitate to contact us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants