Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grr collection E2E test #582

Open
ramo-j opened this issue Apr 8, 2022 · 4 comments
Open

Add grr collection E2E test #582

ramo-j opened this issue Apr 8, 2022 · 4 comments
Assignees

Comments

@ramo-j
Copy link
Collaborator

ramo-j commented Apr 8, 2022

We should have e2e tests for grr collection modules. This would depend on setting up a grr test environment as well.

@ramo-j ramo-j self-assigned this Apr 21, 2022
@tomchop
Copy link
Collaborator

tomchop commented Apr 25, 2022

We have this already in our private jenkins instance, although they're not proper python e2e tests. Is converting them to python what this issue is about?

@ramo-j
Copy link
Collaborator Author

ramo-j commented Apr 26, 2022

This issue started because I managed to miss them in the jenkins test list. However, having found them later, I notice they only run the recipe, and fail if the run fails. There's no checking for correct output as we do in the other e2e's so I think there could be room for improvement.

@tomchop
Copy link
Collaborator

tomchop commented Apr 26, 2022

OK, sounds good, just to make sure we're on the same page :)

@ramo-j
Copy link
Collaborator Author

ramo-j commented Jun 22, 2022

Any changes relating to this should cover the default artefact sets (re: #621)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants