Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AngularJS 1.3 support #14

Open
kevinrenskers opened this issue Oct 14, 2014 · 4 comments
Open

AngularJS 1.3 support #14

kevinrenskers opened this issue Oct 14, 2014 · 4 comments

Comments

@kevinrenskers
Copy link

AngularJS is now giving this error: "Referencing DOM nodes in Angular expressions is disallowed!", because of this: on-drop="controller.dropped(dragEl, dropEl)".

Is there a quick fix for this?

@logicbomb
Copy link
Owner

Yeah, move the code controller.dropped... into a function hanging off of $scope and update the html. It'd be great if you could issue a pull-request with that change.

@kevinrenskers
Copy link
Author

Eh sorry this isn't really clear to me. I think the "update the html" is the main problem that I'm asking a solution for ;) I'm asking for help, so I'm not really in a position to issue any PR (yet).

@kevinrenskers
Copy link
Author

My quick hack is to give the element id's as parameters as opposed to the elements themselves. Let my own function handle the document.getElementById logic. Not sure if this is the best solution, probably not, but works for now.

@logicbomb
Copy link
Owner

Whatever works.

It's been a while since I've used this, but it seems that somewhere there
is an HTML element with the attribute on-drop that is referencing the DOM
elements dragEl and dropEl, which is what angular appears to be
complaining about.

On Tue, Oct 14, 2014 at 10:02 AM, Kevin Renskers [email protected]
wrote:

Eh sorry this isn't really clear to me. I think the "update the html" is
the main problem that I'm asking a solution for ;) I'm asking for help, so
I'm not really in a position to issue any PR (yet).


Reply to this email directly or view it on GitHub
#14 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants