Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut and Paste does not copy the contents of properties #20

Open
1 of 2 tasks
Zyrohex opened this issue Aug 16, 2024 · 3 comments
Open
1 of 2 tasks

Cut and Paste does not copy the contents of properties #20

Zyrohex opened this issue Aug 16, 2024 · 3 comments
Assignees
Labels

Comments

@Zyrohex
Copy link

Zyrohex commented Aug 16, 2024

Search first

  • I searched and no similar issues were found

What Happened?

When using the cut feature (CTRL+X) on a block that contains properties with values, after pasting, the contents of the properties are blank.

Reproduce the Bug

  1. Create a block
  2. Add properties and fill out the values for those properties
  3. Now select the entire block and cut it to your clipboard
  4. Try pasting it in a different page in logseq and notice that the property values are all blank

Expected Behavior

Cut and paste should work the same as copy and paste

Screenshots

chrome_LNSsFbB0l1.mp4

Browser, Desktop or Mobile Platform Information

Logseq DB Test Environment
Commit = logseq/logseq@08d4625

Additional Context

No response

Are you willing to submit a PR? If you know how to fix the bug.

  • I'm willing to submit a PR (Thank you!)
@Zyrohex
Copy link
Author

Zyrohex commented Aug 16, 2024

Another thing on this.. I found that if you do a copy and paste, it works ok.. Unless you go back and delete the original block, then the contents of those property values are wiped out.. The only way this works so that the contents are not wiped out is by dragging and dropping the block into the new location. See the new video for a demonstration:

chrome_QQIU5jiiwM.mp4

@tiensonqin tiensonqin self-assigned this Aug 17, 2024
@tiensonqin tiensonqin added the bug Something isn't working label Aug 17, 2024
tiensonqin added a commit to logseq/logseq that referenced this issue Aug 19, 2024
@tiensonqin
Copy link
Contributor

I just pushed a fix, let me know whether it works for you.

tiensonqin added a commit to logseq/logseq that referenced this issue Aug 19, 2024
@Zyrohex
Copy link
Author

Zyrohex commented Aug 19, 2024

@tiensonqin - cut and paste works now, however if you copy and paste, then delete the original block, the copied block still ends up having its properties wiped out. My guess is its setup to use pointers to not duplicate records in the DB so this will probably fall back on a design question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants