Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field_split_char and value_split_char that properly do escaping. #66

Open
yaauie opened this issue Jul 7, 2018 · 1 comment
Open
Assignees

Comments

@yaauie
Copy link
Contributor

yaauie commented Jul 7, 2018

Injecting verbatim input from field_split and value_split directives into character classes is prone to user error, requiring our users know which characters are meaningful in the regexp context and properly escaping them in their pipeline configs.

When config.support_escapes is enabled, users need to double-escape, which makes things extra tricky.

This ticket is to add two new directives (field_split_char and value_split_char), which will properly escape inputs before generating the character classes.

@colinsurprenant
Copy link
Contributor

@yaauie good idea. maybe we could allow field_split_char to be an array of chars, so if you need to specify multiple chars in the character classes then this will work. It could completely replace the field_split option eventually too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants