Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter::NullObject objects should not be passed through to LS #15

Open
andrewvc opened this issue Jun 22, 2015 · 4 comments
Open

Twitter::NullObject objects should not be passed through to LS #15

andrewvc opened this issue Jun 22, 2015 · 4 comments
Assignees
Labels

Comments

@andrewvc
Copy link
Contributor

On Jruby this gem will return objects with a class of Twitter::NullObject, this is not encodable by JrJackson, and is just not a great idea. This gem should attempt to return all data as standard ruby objects to logstash.

Please see ticket elastic/logstash#3289 for the original report.

@andrewvc andrewvc added the bug label Jun 22, 2015
@andrewvc
Copy link
Contributor Author

Per my discussion with @colinsurprenant I'll be implementing this by adding a monkey patch for Twitter::NullObject#to_json to help JrJackson serialize this.

@andrewvc andrewvc self-assigned this Jun 23, 2015
@andrewvc
Copy link
Contributor Author

This is actually suprisingly tricky due to the fact that Twitter::NullObect inherits from Naught which breaks JrJackson.

I've opened two issues regarding this:
guyboertje/jrjackson#39
sferik/twitter-ruby#704

@andrewvc
Copy link
Contributor Author

This issue is waiting on a logstash release that incorporates JrJackson 0.2.9.

@andrewvc
Copy link
Contributor Author

andrewvc commented Aug 4, 2015

Just leaving a note here, while Logstash 1.5.3 fixes this with a newer JrJackson, its market penetration isn't too high. There's no urgency here, but we should update this in the next few months.

@purbon purbon assigned purbon and unassigned andrewvc Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants