Skip to content

Commit 02df4b7

Browse files
authored
Update to node 6.10.3 and Yarn (#83)
* update to node 6.10.3 and yarn * update .travis.yml
1 parent 653b770 commit 02df4b7

File tree

7 files changed

+1807
-13
lines changed

7 files changed

+1807
-13
lines changed

.nvmrc

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
4.2.6
1+
6.10.3

.travis.yml

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
language: node_js
22
node_js:
3-
- "4.2.6"
3+
- "6.10.3"
44
- stable
55
cache:
6+
yarn: true
67
directories:
78
- node_modules

Dockerfile

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
FROM node:4.4
1+
FROM node:6.10.3
22

33
ADD . /app
44
WORKDIR /app
55

6-
RUN npm install
6+
RUN yarn install
77

8-
ENTRYPOINT ["npm", "start"]
8+
ENTRYPOINT ["yarn", "start"]

Procfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
web: npm start
1+
web: yarn start

README.md

+8-6
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,9 @@ Detailed information on how to interact with Lookerbot [can be found on Looker D
1414

1515
- [Looker](https://looker.com) 3.42 or later
1616
- The "PDF Download & Scheduling and Scheduled Visualizations" Labs feature in Looker must be enabled to display chart images
17-
- A server capable of running [Node.js](https://nodejs.org/en/) to deploy the bot application to
17+
- A web server capable of running [Node.js](https://nodejs.org/) applications to deploy the bot application to
18+
- [Node.js](https://nodejs.org/) 6.10.3 is required
19+
- [Yarn](https://yarnpkg.com/) is required
1820
- (optional) To display chart images, credentials for a supported storage service:
1921
- [Amazon S3](https://aws.amazon.com/s3/) account, bucket, and access keys
2022
- [Documentation](https://docs.aws.amazon.com/AmazonS3/latest/gsg/CreatingABucket.html)
@@ -147,8 +149,8 @@ The `LOOKER_URL`, `LOOKER_API_BASE_URL`, `LOOKER_API_3_CLIENT_ID`, `LOOKER_API_3
147149
To run the server:
148150

149151
1. Ensure Node.js is installed
150-
2. `npm install` to install dependencies
151-
3. `npm start` to start the bot server. The server will run until you type `Ctrl+C` to stop it.
152+
2. `yarn install` to install dependencies
153+
3. `yarn start` to start the bot server. The server will run until you type `Ctrl+C` to stop it.
152154

153155
The included `Procfile` will also allow you to run the app using [foreman](https://github.com/ddollar/foreman) or [node-foreman](https://github.com/jeffjewiss/node-foreman). These libraries also provide easy ways of creating scripts for use with `upstart`, `supervisord`, and `systemd`.
154156

@@ -255,10 +257,10 @@ If you choose to remove the image files from S3, the Slack messages that relied
255257
### Running Locally for Development
256258

257259
1. Install [Node.js](https://nodejs.org/en/) on your local machine.
258-
2. Install [node-foreman](https://github.com/jeffjewiss/node-foreman) with `npm install -g foreman`
260+
2. Install [Yarn](https://yarnpkg.com/) on your local machine.
259261
3. Add your environment variables to a file called `.env` at the base of the repo.
260-
4. Install dependencies with `npm install`
261-
5. Run the bot with `nf start`
262+
4. Install dependencies with `yarn install`
263+
5. Run the bot with `yarn start`
262264

263265
### Contributing
264266

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"mocha": "^2.4.5"
2626
},
2727
"engines": {
28-
"node": "^4.2.6"
28+
"node": "^6.10.3"
2929
},
3030
"repository": {
3131
"type": "git",

0 commit comments

Comments
 (0)