Actually add link open in new tab support... (#322)

Author: Write

ophirofox/settings/options_ui.html

@@ -87,6 +87,13 @@
       <button id="missing_permissions" hidden type="button">
         Autoriser l'accès à Europresse
       </button>
+      <fieldset>
+        <legend>Général</legend>
+        <label>
+          <input type="checkbox" id="open_links_new_tab">
+          Ouvrir les liens Europresse dans un nouvel onglet
+        </label>
+      </fieldset>      
       <fieldset>
         <legend>Partenaire Europresse</legend>
         <p>

ophirofox/settings/options_ui.js

@@ -2,10 +2,12 @@ const choicelist = document.getElementById("partner_choices");
 const template = document.getElementById("partner_template");
 const search = document.getElementById("partner_search");
 const missing_permissions_btn = document.getElementById("missing_permissions");
+const openLinksCheckbox = document.getElementById("open_links_new_tab");
 
-const settings_promise = getSettings();
+let settings = {};
 
-function add_partner(name, settings) {
+// Fonction pour ajouter un partenaire à la liste
+function add_partner(name) {
   const clone = template.content.cloneNode(true);
   const span = clone.getElementById("partner_name");
   /** @type {HTMLInputElement} */
@@ -17,37 +19,49 @@ function add_partner(name, settings) {
     if (input.checked) {
       try {
         await ophirofoxAskPermissions(name);
-        setSettings({ ...settings, partner_name: name });
+        settings.partner_name = name;
+        await setSettings(settings);
         reCheckPermissions(name);
       } catch (err) {
         console.error(err);
-        // restore previous value
         input.checked = false;
       }
     }
   };
 }
 
+// Fonction pour vérifier les permissions
 async function reCheckPermissions(name) {
   missing_permissions_btn.hidden = await ophirofoxCheckPermissions(name);
 }
 
-settings_promise.then((settings) => {
-  ophirofox_config_list.forEach(p => add_partner(p.name, settings));
+// Récupération des paramètres et initialisation de l'interface
+getSettings().then((retrievedSettings) => {
+  settings = retrievedSettings;
+  ophirofox_config_list.forEach(p => add_partner(p.name));
   reCheckPermissions(settings.partner_name);
+  openLinksCheckbox.checked = settings.open_links_new_tab || false;
 });
 
+// Gestion des modifications de la case à cocher
+openLinksCheckbox.onchange = () => {
+  settings.open_links_new_tab = openLinksCheckbox.checked;
+  setSettings(settings);
+};
+
+// Gestion du bouton de permissions manquantes
 missing_permissions_btn.onclick = async () => {
-  const partner_name = current_settings.partner_name;
+  const partner_name = settings.partner_name;
   await ophirofoxAskPermissions(partner_name);
   missing_permissions_btn.hidden = true;
-}
+};
 
+// Gestion de la recherche de partenaires
 search.oninput = () => {
-  const search_term = search.value;
+  const search_term = search.value.toLowerCase();
   const partners = choicelist.getElementsByClassName("partner");
   Array.from(partners).forEach((partner) => {
-    const partner_name = partner.textContent;
-    partner.hidden = !partner_name.toLowerCase().includes(search_term.toLowerCase());
+    const partner_name = partner.textContent.toLowerCase();
+    partner.hidden = !partner_name.includes(search_term);
   });
-}
+};