Skip to content

Commit aa6d163

Browse files
Implement PR feedback
1 parent 148f348 commit aa6d163

File tree

5 files changed

+126
-119
lines changed

5 files changed

+126
-119
lines changed

crates/lox_core/src/bodies/fundamental.rs

+3-2
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,8 @@ mod tests {
172172

173173
// Relative error tolerance for float_eq assertions.
174174
// This is somewhat loose, being based on observations of how closely our implementations
175-
// match ERFA outputs rather than any target TOLERANCE.
175+
// match ERFA outputs rather than any target tolerance.
176+
// See https://github.com/lox-space/lox/pull/23#discussion_r1398485509
176177
const TOLERANCE: f64 = 1e-11;
177178

178179
// Test cases for t.
@@ -185,7 +186,7 @@ mod tests {
185186
assert_float_eq!(
186187
general_accum_precession_in_longitude(T_ZERO),
187188
0.0,
188-
rel <= TOLERANCE
189+
abs <= TOLERANCE
189190
);
190191
assert_float_eq!(
191192
general_accum_precession_in_longitude(T_POSITIVE),

crates/lox_core/src/bodies/nutation.rs

+4-4
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,11 @@ struct Coefficients {
3535
/// `Ω`.
3636
om: f64,
3737
/// Longitude sine.
38-
long_sin_1: f64,
39-
long_sin_t: f64,
38+
sin_psi_1: f64,
39+
sin_psi_t: f64,
4040
/// Obliquity cosine.
41-
obl_cos_1: f64,
42-
obl_cos_t: f64,
41+
cos_eps_1: f64,
42+
cos_eps_t: f64,
4343
}
4444

4545
/// Calculate nutation coefficients at `epoch` using the given [Model].

0 commit comments

Comments
 (0)