Fixing bugs on inheritance system and add free primary key capability #98
Conversation
|
Perhaps a test could be added? Fix looks good enough. |
…me every name. It need a getter method properly implemented. Added a test FreePrimaryKey. Added a inheritance test to show that previous fix is working
|
Added test you have request. I have added another feature(I hope you like it). |
|
Seems like some other changes slipped in from the original request. |
|
Do you prefer that I split all in 2 pull requests? |
|
Not necessarily, but please update the PR to include some details about the purpose of the change. Also, I know it's been lingering for a while, but could you look into that authentication failure issue? |
|
In later versions of Neo4j it was introduced an authentication system . There are two solutions to our problem , disable the authentication in config or send an authentication header every request. |
mmeloni
changed the title
|
First option looks good.
|
|
I have no idea how to do it in travis...it's up to you right? |
|
That was harder than expected. I just merged a few commits that fix the build process. Please update your branch. |
|
Ok, all is green. What's your opinion? |
| { | ||
| $meta = $this->getMeta($entity); | ||
| $pk = $meta->getPrimaryKey(); | ||
| $pkGetter = 'get'.ucfirst($pk->getName()); |
There was a problem hiding this comment.
The reflected property should allow to read the value directly from the property rather than relying on the naming convention. There used to be a lot of this, but it has since been removed.
I fail to understand the purpose of the change. Is it not possible to use @auto on an arbitrary property?
|
Any news? It's our intention to remain in sync with main repo. |
Some bug fixes