From 76d6f2a757efaff9a47aaa36f77aae5bb70a6ad1 Mon Sep 17 00:00:00 2001 From: Lakshya Taragi Date: Mon, 2 Sep 2024 16:41:13 +0530 Subject: [PATCH] Change default value of MAX_SHARDS_ALLOWED_IN_STATUS_API Signed-off-by: Lakshya Taragi --- .../org/opensearch/snapshots/SnapshotStatusApisIT.java | 4 ++-- .../java/org/opensearch/snapshots/SnapshotsService.java | 7 +++++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/server/src/internalClusterTest/java/org/opensearch/snapshots/SnapshotStatusApisIT.java b/server/src/internalClusterTest/java/org/opensearch/snapshots/SnapshotStatusApisIT.java index 1bf6140b6ded0..5a043e69e9735 100644 --- a/server/src/internalClusterTest/java/org/opensearch/snapshots/SnapshotStatusApisIT.java +++ b/server/src/internalClusterTest/java/org/opensearch/snapshots/SnapshotStatusApisIT.java @@ -52,9 +52,9 @@ import org.opensearch.common.util.io.IOUtils; import org.opensearch.core.common.Strings; import org.opensearch.core.common.unit.ByteSizeUnit; -import org.opensearch.repositories.IndexId; import org.opensearch.core.rest.RestStatus; import org.opensearch.index.IndexNotFoundException; +import org.opensearch.repositories.IndexId; import org.opensearch.repositories.blobstore.BlobStoreRepository; import org.opensearch.threadpool.ThreadPool; @@ -70,8 +70,8 @@ import java.util.concurrent.TimeUnit; import java.util.stream.Collectors; -import static org.opensearch.test.OpenSearchIntegTestCase.resolvePath; import static org.opensearch.snapshots.SnapshotsService.MAX_SHARDS_ALLOWED_IN_STATUS_API; +import static org.opensearch.test.OpenSearchIntegTestCase.resolvePath; import static org.opensearch.test.hamcrest.OpenSearchAssertions.assertAcked; import static org.hamcrest.Matchers.equalTo; import static org.hamcrest.Matchers.greaterThan; diff --git a/server/src/main/java/org/opensearch/snapshots/SnapshotsService.java b/server/src/main/java/org/opensearch/snapshots/SnapshotsService.java index 8ea3495a00fd9..232dbe946d2ae 100644 --- a/server/src/main/java/org/opensearch/snapshots/SnapshotsService.java +++ b/server/src/main/java/org/opensearch/snapshots/SnapshotsService.java @@ -204,10 +204,13 @@ public class SnapshotsService extends AbstractLifecycleComponent implements Clus Setting.Property.Dynamic ); - // TODO: discuss values and name to be used here + /** + * Setting to specify the maximum number of shards that can be included in the result for the snapshot status + * API call. Note that it does not apply to V2-shallow snapshots. + */ public static final Setting MAX_SHARDS_ALLOWED_IN_STATUS_API = Setting.intSetting( "snapshot.max_shards_allowed_in_status_api", - 1000, + 200000, 1, Setting.Property.NodeScope, Setting.Property.Dynamic