Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I miss the reporting of changes to current temperature #146

Open
PuzzledUser opened this issue Mar 20, 2023 · 1 comment
Open

I miss the reporting of changes to current temperature #146

PuzzledUser opened this issue Mar 20, 2023 · 1 comment

Comments

@PuzzledUser
Copy link

I know you decluttered the logging recently, but I miss seeing current temp changes. I used to consult the log now and again (e.g. to see why was it cold this morning when I woke up). I see you have various options in Settings. Would you consider adding one for log changes of current temperature?

It could enable code like this I've hacked in around line 460:

 this.log(
	 device.name +
	 " temp " +
	 (oldCurrentTemp < newCurrentTemp ? "increased from: " : "decreased from: ") +
	 oldCurrentTemp +
	 " to: " +
	 newCurrentTemp
 );

P.S. why does Evohome fake a change to current temperature when the target changes (past the current)? 🤔

@PuzzledUser
Copy link
Author

PuzzledUser commented Mar 20, 2023

By the way, did you accidentally overlook changing the logging to debug at line 916 (too wordy) and 969 (there is another log entry for that change a few seconds later)? The associated ones are now that.log.debug...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants