-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kanban Board setup #21
Comments
Hi Team,Good job so far!To Highlight! 👏 🟢✔️ Good job with issue description There are some issues that you still need to work on to get this project approved, but you are almost there! Status: Requires Changes ♻️Check the comments under the review.
Optional suggestionsEvery comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. N/ACheers and Happy coding!👏👏👏 Feel free to leave any questions or comments in the PR thread if something is not 100% clear or you can get to me on slack using this handle @Mihndim. Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise. As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form. |
Hi @lucascomamala , Great work on making the changes requested by a previous reviewer 👏 Highlights
Required Changes ♻️
Check the comments under the review. Optional suggestionsEvery comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application. Cheers and Happy coding!👏👏👏 Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise. As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form. |
I started again with a new project and ran into the exact same issue which leads me to believe that it's the script that's not working properly. I went ahead and added the missing cards manually. |
Hi Team,Your project is complete! There is nothing else to say other than... it's time to merge it Congratulations! 🎉Cheers and Happy coding!👏👏👏Feel free to leave any questions or comments in the PR thread if something is not 100% clear. As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form. |
2 person team
https://github.com/lucascomamala/space-travelers-hub/projects/1
The text was updated successfully, but these errors were encountered: