Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kanban Board setup #21

Open
lucascomamala opened this issue Sep 27, 2022 · 4 comments
Open

Kanban Board setup #21

lucascomamala opened this issue Sep 27, 2022 · 4 comments

Comments

@lucascomamala
Copy link
Owner

2 person team

https://github.com/lucascomamala/space-travelers-hub/projects/1

@Mihndim2020
Copy link

Mihndim2020 commented Sep 27, 2022

Hi Team,

Good job so far!

To Highlight! 👏 🟢

✔️ Good job with issue description

There are some issues that you still need to work on to get this project approved, but you are almost there!
ALMOST-MINION

Status: Requires Changes ♻️

Check the comments under the review.

  • Please make sure you have 17 cards in your kanban board, only cards with Team3 prefix should be removed.
  • Please make sure all the cards are assigned among the team members and in a fair way, each team member should have cards in these categories: Setup, Fetch data, Lists render, Actions, Conditional components, Filters. Something like so:

kanbanBoard

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

N/A

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear or you can get to me on slack using this handle @Mihndim.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Ugboaja-Uchechi
Copy link

Ugboaja-Uchechi commented Sep 27, 2022

Hi @lucascomamala ,

Great work on making the changes requested by a previous reviewer 👏
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.

Highlights

  • Great job creating an Issue👍

Required Changes ♻️

  • Like the previous reviewer mentioned kindly make sure you have 17 cards in your Kanban board 🙏 . The cards for group tasks and create basic structure for rockets are missing. Kindly add them.
Missing Cards Missing Cards
image image

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@lucascomamala
Copy link
Owner Author

I started again with a new project and ran into the exact same issue which leads me to believe that it's the script that's not working properly. I went ahead and added the missing cards manually.

@DeliceLydia
Copy link

Hi Team,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:

Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants