-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP/2 headers should all be lowercase #1060
Labels
Comments
should this be a patch to the Crystal project? |
Yeah, it probably should be. Does the HTTP::Server even support HTTP/2 yet? |
I do not believe so. |
With servers like Caddy enabling HTTP/3 .... I wonder if there's stuff we would need to consider 🤔 I know less than Jon Snow about it all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
According to the HTTP/2 spec, all headers should be lowercase.
Currently crystal handles checking against lowercase vs uppercase, and dashes vs underscores, so
CONTENT_TYPE
is the same ascontent-type
. We could safely lowercase, and dasherize for convention any place that we mention a header key directly.This also makes me curious to know what else we would need to do to ensure we fully support HTTP/2? 🤔
The text was updated successfully, but these errors were encountered: