Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP/2 headers should all be lowercase #1060

Open
jwoertink opened this issue Mar 22, 2020 · 4 comments
Open

HTTP/2 headers should all be lowercase #1060

jwoertink opened this issue Mar 22, 2020 · 4 comments

Comments

@jwoertink
Copy link
Member

According to the HTTP/2 spec, all headers should be lowercase.

Currently crystal handles checking against lowercase vs uppercase, and dashes vs underscores, so CONTENT_TYPE is the same as content-type. We could safely lowercase, and dasherize for convention any place that we mention a header key directly.

This also makes me curious to know what else we would need to do to ensure we fully support HTTP/2? 🤔

@jkthorne
Copy link
Contributor

should this be a patch to the Crystal project?

@jwoertink
Copy link
Member Author

Yeah, it probably should be. Does the HTTP::Server even support HTTP/2 yet?

@jkthorne
Copy link
Contributor

I do not believe so.
but there is a reasonably well implementation here https://github.com/ysbaddaden/http2

@jwoertink jwoertink added the hacktoberfest Valid Issue for Hacktoberfest label Oct 1, 2021
@jwoertink jwoertink removed the hacktoberfest Valid Issue for Hacktoberfest label Nov 1, 2021
@jwoertink jwoertink added the hacktoberfest Valid Issue for Hacktoberfest label Oct 1, 2022
@jwoertink
Copy link
Member Author

With servers like Caddy enabling HTTP/3 .... I wonder if there's stuff we would need to consider 🤔 I know less than Jon Snow about it all

@jwoertink jwoertink removed the hacktoberfest Valid Issue for Hacktoberfest label Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants