Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate other CI/CD config files? #1077

Open
arschles opened this issue Apr 2, 2020 · 5 comments
Open

Generate other CI/CD config files? #1077

arschles opened this issue Apr 2, 2020 · 5 comments

Comments

@arschles
Copy link

arschles commented Apr 2, 2020

Hi folks, I just started using Lucky today. This thing looks awesome! The first thing I noticed is that it generates a skeleton Travis CI config file (.travis.yml). I was wondering if you'd be open to having it generate other files as well? If so, I'm happy to submit PRs to have it generate Drone CI and GitHub actions.

Feel free to let me know, and if you're not ok with it, not a problem in the world 😄

@jwoertink
Copy link
Member

jwoertink commented Apr 2, 2020

Hey @arschles! Welcome to Lucky 🎉

This file is actually generated by crystal https://github.com/crystal-lang/crystal/blob/8934d4e91bd7a47d3dabca82fd002522dadca18a/src/compiler/crystal/tools/init.cr#L298 I suspect it's because travis gives you free CI when your project is open source. Lucky just generates a standard crystal app, then fills in the extra bits around it. I think having built-in github actions would be neat, or at least an easy tutorial on how to add it in. Maybe we could just make some documentation on our website on how to switch that out? What do you think about that?

@paulcsmith
Copy link
Member

Yeah Travis was originally because crystal had it so we modified it. Travis has since gone downhill a bit. I’d love to have a GitHub actions file built in and have docs for others in the website. Most everyone uses GitHub and being able to just push your repo and have it work would be amazing!!

@paulcsmith
Copy link
Member

And thanks for the kind words! Welcome to Lucky 🍀

@arschles
Copy link
Author

arschles commented Apr 7, 2020

Thanks @jwoertink and @paulcsmith. I'm new to crystal and lucky. I really appreciate the framework and how welcoming you all are.

I had no idea the travis file is generated from crystal. I assumed it was the lucky CLI! I'm cool with writing some documentation for how to add it for now. Should it go in the lucky docs?

@paulcsmith
Copy link
Member

@arschles We're glad yo have you! And yes some guides would be really cool. Maybe in the new testing section! The gist is that you would duplicate one of these other guides: https://github.com/luckyframework/website/blob/master/src/actions/guides/testing/introduction.cr and then add the guide to the sidebar links https://github.com/luckyframework/website/blob/a8a8005635f13602b4cec4fb1eb7f9a6af0f763e/src/models/guides_list.cr#L60-L65. If you wanted to do that it'd be awesome! Even a basic draft would be 💯

And just to clarify the travis.yml is generated by Crystal, but we modify it heavily to make it work with Lucky out of the box. I'm totally ok switching to GitHub actions once we get a working version. I haven't spent any time on that, but hopefully one of these days we can do it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants