Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a guide for testing with CI/CD systems #283

Closed
wants to merge 1 commit into from

Conversation

arschles
Copy link

@arschles arschles commented Apr 15, 2020

Fixes luckyframework/lucky#1077

TODO:

  • These docs need to add a shards install command to the GH action

Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I think this will be a huge bonus. I know a lot of people prefer setting these up. I just have a few small changes, but overall I think this is the right direction.

@@ -0,0 +1,60 @@
class Guides::Testing::Introduction < GuideAction
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class name should be Guides::Testing::ContinuousIntegration or something like that. We have an Introduction class already.

automatically run tests for you. Below is a list of systems
that are free and popular for open source projects:

- [Travis CI](https://travis-ci.org/) - The `lucky` CLI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you mention that Lucky generates this just below, maybe we can leave it off of this spot?


Lucky already generates a config file for
[Travis CI](https://travis-ci.org/), so if you choose to use
that platform, congratulatioins! You're done.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about something like:

Lucky generates the TravisCI config file for you when you create your app.

But you're not really done at that point, right? Or are you? I don't really know how that works. Does github just sync those up when you have that config file?

and clicking on the green button in the top right corner
of the page.
MD
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spacing here.

@stephendolan
Copy link
Member

@jwoertink Do you think this is worth re-opening at this point?

@jwoertink
Copy link
Member

Yeah, I think it would be cool to have section dedicated to getting setup with a CI where we could give a quick example on travis, circle, and github actions. This PR was a decent start, but just needed a few quick changes. @stephendolan if you wanted to open a different PR with your take on it, I'm open to that. We're almost 6 months stale on this now.

@stephendolan
Copy link
Member

Cool, opened #439 to track on this.

@stephendolan
Copy link
Member

Since this is pretty stale, closing so that we have it as a reference for the resolution of #439 but can get a fresh take on it now that we're in a GitHub Actions kind of world.

@arschles
Copy link
Author

arschles commented Nov 6, 2020

Sorry I left this for so long everyone. I don't think I'm going to be able to contribute on this addition at the moment but I work for Microsoft and I'm happy to help get actions working. Feel free to ping me

@arschles arschles deleted the ci-cd-docs branch November 6, 2020 21:02
@jwoertink
Copy link
Member

Hey no worries @arschles. We appreciate you getting this started! It's definitely something we want. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate other CI/CD config files?
3 participants