Suggestion: Change UploadedFile name to use HTTP::FormData::Part filename

[rnice01]

I have an app where I upload an image and save it locally. I was saving the file using the Lucky::UploadedFile name attribute in my action and noticed the saved file was using the name of the form field and losing the extension name as well. I noticed tempfile was another attribute and attempted to use tempfile.name but got the same result as the temp file gets created using part.name as well.

I looked in the source code and figured out I could get the filename through UploadedFile.metadata.filename. Which is fine since now I know how to get the filename. However, I feel others could also run into this problem as well thinking UploadedFile.name will yield a filename.

So changing this line to use part.filename instead of part.name.

[UnsolvedCypher]

The filename could be nil though, so what would you propose is used as a fallback? I think the inconsistent behavior (when the filename is nil or not) might be more confusing than just keeping it as the field name.

[rnice01]

@UnsolvedCypher if Part.filename is nil then Part.name could be the fallback. I could be totally alone here, but I feel that calling UploadedFile.name should try to provide the filename if possible, given the name of the class has File in it.

[UnsolvedCypher]

No I agree that the current behavior is confusing, I ran into the same issue yesterday 😄 . I just think that having the .name behave differently depending on whether or not the file name is available would cause bugs for people who don't realize it behaves this way. Maybe the name attribute could just be renamed to field_name or param_name so it's more obvious what it does?

[rnice01]

Ah I see, you're right, changing it to either be the filename or part name would be just as confusing. I like the idea of changing the attribute name to either field_name or param_name.