Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #1152 by adding a new
mount_with_defaults
method that can inject some helpful defaults into components.Description
I'd like to get some feedback from others before I go too far down any given path. That said, I've got the thing that was blocking me working. Say we have a component with a
form
, like this:This is a really nice abstraction, and greatly cleans up the duplication between
edit_page.cr
andnew_page.cr
for theFilter
model, in this case.I'm not super thrilled about having to manually add
needs context
andneeds current_user
to the component, but also not sure if we can inject that after the component is initialized so that it's available but invisible.The use of this component looks something like this:
To-do
mount_with_defaults
Checklist
crystal tool format spec src
./script/setup
./script/test