New skip_browsersync_checks flag on lucky watch #1517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… browsersync checks. Fixes #1255
There was a problem hiding this comment.
I'm hesitant about adding a rather obscure command line flag that disables a small piece of code.
What are your thoughts about documenting that Alpine Linux needs to install lsof? We would just document that they need to run apk add lsof if they want to run lucky in dev mode
|
For reference, I googled "alpine linux lsof" and the second result is a stack overflow link where the question is about this and the answer was to just install lsof instead of relying on alpine's. https://stackoverflow.com/questions/54487561/can-lsof-show-open-ports-on-alpine-linux |
|
I'm cool with that 👍 I wasn't too keen on this either, but I don't use Alpine, so I don't know anything about it 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #1255
Description
On some systems like Alpine Docker, the current browsersync checks may not work. You already have the option to just disable browsersync (removing the
--reload-browserflag), but in the case where you still want Lucky to handle browsersync, this new--skip-browsersync-checksflag will skip checking if the port is available.Eventually, it would be nice to have commands that are fully cross-platform compatible as Crystal gets closer to being fully native on Windows. For now, this is the easy hack around it.
Checklist
crystal tool format spec src./script/setup./script/test