onMissingChildren #142
ChristopherMeek
started this conversation in
Ideas
Replies: 1 comment
-
Time to dredge up some zombie discussions! @lukasbach any thoughts around this one? I think what @ChristopherMeek is proposing seems reasonable, and I'm happy to take a stab at it, but wasn't 100% sure what you were thinking as far as supporting this prop. Edit: Ended up going in a different direction here that works for me, but would still be happy to help if this is something desired in the lib! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hey All,
I'm trying to put together a PR to complete the onMissingChildren functionality. Modifying TreeItem to do a check similar to the missing item check is straightforward enough, something like ...
This works fine for controlled environments. For uncontrolled environments a bit more work needs to be done to the dataprovider and UncontrolledEnvironment. I'm thinking of adding
getChildren?: (itemId: TreeItemIndex) => Promise<TreeItemIndex[]>;
to theTreeDataProvider
interface and then anonMissingChildren
handler toUncontrolledEnvironment
that pushes the received ids into item in much the same way asonMissingItems
.Of course I will add tests, test-data and stories to complete the PR.
Does this sound like a reasonable approach?
Beta Was this translation helpful? Give feedback.
All reactions