Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide orientation options to Macrocycles for whether a building block points in/out #471

Open
andrewtarzia opened this issue Sep 30, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@andrewtarzia
Copy link
Collaborator

From a discussion with @fiszczyp , where large-ish building blocks were pointing into the centre of the macrocycle when isometric smiles were used (I could not understand this distinction, but currently I think the initial conformer orienation/structure will impact orientation somehow).

I think the solution to this is a new Orientable(?)Macrocycle topology graph that allows the user to provide vectors OR (my preference) a selection out of "up", "down", "in", "out" vertices that would then align all of those Building blocks along the ring in that direction.

This requires:

  • New macrocycle topology graph that allows for different vertex selections in initialiser.
  • New macrocycle vertices that provide orientation of core along some vectors:
    • in: -core-placer along edge_centroid
    • out: core-placer along edge_centroid
    • up: core-placer along [001]
    • down: core-placer along [00-1]
  • New tests and edge cases for when the building block is large/complex or small.
@andrewtarzia andrewtarzia added the enhancement New feature or request label Sep 30, 2022
@lukasturcani
Copy link
Owner

is this related to #15 ?

@andrewtarzia
Copy link
Collaborator Author

Related, but probably adds a bit more in terms of control??

@lukasturcani
Copy link
Owner

fair

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants