Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Angular 17 #188

Open
miribo opened this issue Dec 14, 2023 · 5 comments
Open

Add support for Angular 17 #188

miribo opened this issue Dec 14, 2023 · 5 comments

Comments

@miribo
Copy link

miribo commented Dec 14, 2023

Please update the dependencies and other necessary code so that the project supports Angular 17

@simeonhearring
Copy link

simeonhearring commented Dec 29, 2023

I'm using Angular 17 and getting this error when using ngx-summernote 1.0.0...
[INFO] npm WARN [email protected] requires a peer of @angular/[email protected] - 16.x but none is installed. You must install peer dependencies yourself.

@dancornilov
Copy link

Until this issue will be fixed, you can overwrite in your package.json peer dependency.

{
...
"dependencies": {...},
"devDependencies": {...},
"overrides": {
    "ngx-summernote": {
      "@angular/common": "14.x - 17.x",
      "@angular/core": "14.x - 17.x",
      "@angular/forms": "14.x - 17.x"
    }
  }
}

@ihor-shturmov
Copy link

ihor-shturmov commented Jan 11, 2024

Hi, library doesn't work for me after I've updated Angular to version 16.

getting this:
This likely means that the library (ngx-summernote) which declares NgxSummernoteModule is not compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy.

Tried what @dancornilov mentioned, didn't work.
So I would like to know if there are any solution or ETA of having it?

@ihor-shturmov
Copy link

@lula hi, just wondering if you could tell if there will be an update for the library to work with newest versions of the framework any day soon?

@reinoboonstra
Copy link

Still no answer, that doesn't sound good. Skipping this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants