Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest aspect and compiler #138

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jtenner
Copy link
Contributor

@jtenner jtenner commented Sep 1, 2022

233 tests pass.

Let's see how things work on CI...

trusktr
trusktr previously approved these changes Sep 2, 2022
@@ -44,30 +44,30 @@
"prepare": "npm run build && npm rebuild --build-from-source gl"
},
"dependencies": {
"@assemblyscript/loader": "^0.19.3",
"@as-pect/cli": "^7.0.7",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a particular reason to move the cli to dependencies? Or just accidental?

"live-server": "^1.2.1",
"@types/node": "^18.7.14",
"assemblyscript": "^0.21.3",
"deasync": "^0.1.28",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks like we can remove some dependencies that were needed for importSync.

@trusktr trusktr changed the base branch from master to main September 7, 2022 16:01
@trusktr
Copy link
Member

trusktr commented Sep 7, 2022

Note, changed the base branch to main, deleted master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants