Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more recent LuaSocket versions #159

Open
catwell opened this issue Jan 11, 2023 · 4 comments
Open

Support more recent LuaSocket versions #159

catwell opened this issue Jan 11, 2023 · 4 comments

Comments

@catwell
Copy link
Member

catwell commented Jan 11, 2023

Is there a reason why the rockspec constrains LuaSocket to = 3.0rc1-2 (as of 4.6.0)? This is an old version which does not work well with Lua 5.4.3+ because of lunarmodules/luasocket#334

@Tieske
Copy link
Member

Tieske commented Jan 11, 2023

I think it was because of lunarmodules/luasocket#371, but don't recall exactly. the constraint is there since 3.0.0-3.

Have you tried it with 3.1?

@Tieske
Copy link
Member

Tieske commented Jan 11, 2023

here it is: #114

@catwell
Copy link
Member Author

catwell commented Jan 11, 2023

I have tried very basic thing (a HTTP request) with 3.1 and it works. What prompted this was testing your PR on my repository! catwell/lua-http-digest@7563309

@Tieske
Copy link
Member

Tieske commented Jan 12, 2023

Created a new PR to recreate the issues we had before; #160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants