Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect behaviour on url generation. #1981

Open
AaronNeonDigital opened this issue Oct 8, 2024 · 0 comments
Open

Incorrect behaviour on url generation. #1981

AaronNeonDigital opened this issue Oct 8, 2024 · 0 comments
Labels
bug Something isn't working unconfirmed

Comments

@AaronNeonDigital
Copy link
Contributor

AaronNeonDigital commented Oct 8, 2024

  • Lunar version: ^1.0.0-alpha.24
  • Laravel Version: 11
  • PHP Version: 8.3
  • Database Driver & Version:

Expected Behaviour:

The URL Generator should check if the table column has a name field, and prioritise that column before trying to slugify the attribute_data, saving on duplication in tables. As an example, the lunar_brands table.

Actual Behaviour:

If a model has attribute_data but also a name column (so it doesn't use the name attribute) and it also has URLs, the slug is blank because the generator is looking for a name attribute when it doesn't exist, the name column should either be a priority check or if no name attribute value is available, use the name column if possible

Steps To Reproduce: N/A

@AaronNeonDigital AaronNeonDigital added bug Something isn't working unconfirmed labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working unconfirmed
Projects
None yet
Development

No branches or pull requests

1 participant