Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SystemTaxDriver only works with postcode-based tax zones #755

Closed
webcraft opened this issue Nov 25, 2022 · 2 comments
Closed

SystemTaxDriver only works with postcode-based tax zones #755

webcraft opened this issue Nov 25, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@webcraft
Copy link
Contributor

  • Lunar version: 0.1.4
  • Laravel Version: 8.83.26
  • PHP Version: 8.1.8
  • Database Driver & Version: mysql 8

Expected Behaviour:

I added country based tax zones, one for every country in the EU. I expect the SystemTaxDriver to use the appropriate tax zone depending on the shipping address country.

Actual Behaviour:

In reality, it always uses the default tax zone.
The GetTaxZone class seem to only take into account postcode-based tax zones. So also no state-based tax zones.

Steps To Reproduce:

Add some country based tax zones with different tax rates (and no postcode based ones).
Do a checkout and change the shipping address country.
Observe that the tax rate never changes but is always the default one.

@webcraft webcraft added the bug Something isn't working label Nov 25, 2022
@alecritson
Copy link
Collaborator

@webcraft Was this resolved in your PR #1248

@alecritson
Copy link
Collaborator

Closing as this should be resolved from 0.5.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants