Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Dependabot not working #208

Closed
samuelburnham opened this issue Dec 20, 2023 · 1 comment · Fixed by #215
Closed

ci: Dependabot not working #208

samuelburnham opened this issue Dec 20, 2023 · 1 comment · Fixed by #215
Labels
bug Something isn't working CI Continuous Integration related issues

Comments

@samuelburnham
Copy link
Contributor

A dependabot.yml was added four months ago in #4, but doesn't seem to have created any pull requests for Cargo or GitHub Actions. It should be scanning weekly for GitHub Actions, but we still have an outdated actions/checkout action in https://github.com/lurk-lab/arecibo/blob/dev/.github/workflows/rust.yml#L29

An identical configuration appears to working at least for GitHub Actions in lurk-rs, but it's unclear if the Cargo updates are working in either repo.

@samuelburnham samuelburnham added CI Continuous Integration related issues bug Something isn't working labels Dec 20, 2023
@huitseeker
Copy link
Contributor

Dependabot doesn't support our rust-toolchain file which is antiquated:
https://github.com/lurk-lab/arecibo/network/updates/764791367

In our case, our non-toml rust-toolchain file is here because:

  • we like pinning the rust version,
  • we're still using an old action to install the toolchain, which only supports this old format

We should instead use https://github.com/dtolnay/rust-toolchain except this is not great at supporting a pinned toolchain:
dtolnay/rust-toolchain#92

One solution could be to go for a 'running' stable rust version, biting the bullet of the clippy incompatibilities at each release.
This probably also affects Lurk-rs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI Continuous Integration related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants